Frederick888 / external-editor-revived

External Editor Revived is a Thunderbird MailExtension which allows editing emails in programs such as Vim, Neovim, Emacs, etc.
GNU General Public License v3.0
113 stars 6 forks source link

v0.5.0 is not working on Debian stable (bullseye) #87

Closed b3 closed 1 year ago

b3 commented 1 year ago

Description

Downloading the 0.5.0 release ubuntu-latest-native-messaging-host-v0.5.0.zip give a binary which is not working on Debian bullseye (used libc is not available) :

$ ./external-editor-revived 
./external-editor-revived: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.33' not found (required by ./external-editor-revived)
./external-editor-revived: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.32' not found (required by ./external-editor-revived)
./external-editor-revived: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by ./external-editor-revived)

When trying to compile with cargo the same problem with tools availabilty arise:

$ cd /tmp/external-editor-revived-0.5.0/src && cargo build
error: failed to parse manifest at `/tmp/external-editor-revived-0.5.0/Cargo.toml`

Caused by:
  failed to parse the `edition` key

Caused by:
  this version of Cargo is older than the `2021` edition, and only supports `2015` and `2018` editions.

Environment

Frederick888 commented 1 year ago

So it finally happened :)

I don't (or plan to) take care of these kinds of packaging or distribution issues other than the AUR one. (And if I ever stop using Arch, I'll probably drop it as well.)

I'm pretty sure there are lots of other distros where things don't work out of the box either. But I believe it's ultimately the packagers' issue to tackle this. Talking about Debian and Rust in particular, there have been quite a few discussions most recently at https://github.com/fish-shell/fish-shell/pull/9512 AFAIK, and I'm confident they can figure something out. Of course still this can only happen if this project grows in popularity, so star it and share it with your friends and colleagues!

In the meanwhile I suggest you obtain the latest compiler from https://rustup.rs and compile from source. You should also be able to target MUSL for even better portability.

Frederick888 commented 1 year ago

I tweaked my CI a bit to target musl as well. You can test the artefacts of https://github.com/Frederick888/external-editor-revived/pull/88.

Frederick888 commented 1 year ago

Merged. The artefacts are also available at https://github.com/Frederick888/external-editor-revived/actions/runs/4075636138 now. Next release should have musl as well.