FrederoxDev / Amethyst-Launcher

Launcher for Minecraft Bedrock mods created with AmethystAPI
27 stars 5 forks source link

[BUG] Issues when installing profile #1

Closed ATXLtheAxolotl closed 2 months ago

ATXLtheAxolotl commented 4 months ago

Version: 2.1.0-pre-release Profile: 1.20.51.1 Type: Vanilla

When you start the launcher without a a mods folder in Amethyst the launcher throws an error, leaving the screen white.

Uncaught Error: ENOENT: no such file or directory, scandir 'C:\Users\USER\AppData\Local\Packages\Microsoft.MinecraftUWP_8wekyb3d8bbwe\AC\Amethyst\mods'
    at Object.readdirSync (node:fs:1527:3)
    at t.readdirSync (node:electron/js2c/asar_bundle:2:11295)
    at Modlist.ts:23:28
    at AppState.tsx:61:25
    at as (react-dom.production.min.js:244:332)
    at xu (react-dom.production.min.js:286:111)
    at react-dom.production.min.js:282:391
    at k (scheduler.production.min.js:13:203)
    at Immediate.R (scheduler.production.min.js:14:128)
    at process.processImmediate (node:internal/timers:476:21) 

When the launcher is registering the downloaded game it asks me to use the Microsoft store to find something to open the Minecraft url. image

FrederoxDev commented 4 months ago

Does the open in Microsoft store issue persist or is it just a one time issue when you install the version for the first time?

Also for now just manually make the mod folder, will fix in the next update 👍

ATXLtheAxolotl commented 4 months ago

The Microsoft store prompt is a reoccurring issue that I have.

FrederoxDev commented 4 months ago

Could you try deleting the downloaded version of 1.20.51.1? It will be installed in amethysts folder in app data. Simply just delete the .appx file and the folder in the versions folder.

Then try launching again

ATXLtheAxolotl commented 4 months ago

I seem to still have the issue after deleting the version.

FrederoxDev commented 4 months ago

Just to double check it went through all the steps of downloading and unzipping the version?

Maybe it's failing to register the version.. every time you press launch does it try to register again?

If so try running it in admin

FrederoxDev commented 4 months ago

If it doesn't work with admin try pressing CTRL + SHIFT + I and go to console, see if there is anything logged there

ATXLtheAxolotl commented 4 months ago

The launcher showed the zip state but I didn’t check the console nor try it in administrator. Once I get back from dinner, I will have to reinstall the game through another launcher first since Amethyst-Launcher requires the mods folder on launch. I’m suspecting its an admin issue but it could be the zip

ATXLtheAxolotl commented 4 months ago

The issue persists when ran in admin. The zip output had no issues and no errors were printed to console.

ATXLtheAxolotl commented 4 months ago

I'm going to try and log the powershell registration command and see if it has any issues.

ATXLtheAxolotl commented 4 months ago

Well I fixed it but I can't remember what I changed, give me a minute to make a PR. my brain is too tired

ATXLtheAxolotl commented 4 months ago

Fixed it somewhat I just now get this strange prompt: image

ATXLtheAxolotl commented 4 months ago

Strangely enough the game seems to self-terminate when it has a launcher_config.json I'm guessing the proxy doesn't like the vanilla runtime

FrederoxDev commented 4 months ago

Strangely enough the game seems to self-terminate when it has a launcher_config.json I'm guessing the proxy doesn't like the vanilla runtime

Yeah the vanilla option hasn't been implemented yet xd, known issue.

Right now the runtime just instantly closes itself, which takes the game down with it.

KerbinCenturion commented 2 months ago

I am having the same issue with the program asking me to use the Microsoft store to find something to open the Minecraft URL. When I "register" the program in Amethyst it deletes the base Minecraft game and then the store popup gets displayed, I have tried a lot of things so far but no dice.

ATXLtheAxolotl commented 2 months ago

Yeah it tends to do this when it fails to install the game; I’m thinking we should move back the data restore point if it fails at some point in the re-install game.

FrederoxDev commented 2 months ago

Yeah, the issue is that we haven't really had a way to reproduce this issue. Could we get some information?:

FrederoxDev commented 2 months ago

P.s. all your games data should be in the %appdata%/Amethyst/DataRestorePoint/ folder, it might be worth making a manual copy if you have stuff you care about in there

Tallis-Larsen commented 2 months ago

1: I did use the minecraft launcher to switch between latest java release and 1.8 for combat purposes a while ago.

  1. No. only the minecraft launcher and minecraft preview do
  2. Latest release (1.20.73. i believe)
FrederoxDev commented 2 months ago

Thanks, from some debugging we eventually figured out that:

If we get another person having these issues:

FrederoxDev commented 2 months ago

Should be automatically handled in launcher version 2.3.0, commit: 1b1add47341345d3710fc3607bed1fe24c7e3e63

KerbinCenturion commented 2 months ago

I am having the same issue with the program asking me to use the Microsoft store to find something to open the Minecraft URL. When I "register" the program in Amethyst it deletes the base Minecraft game and then the store popup gets displayed, I have tried a lot of things so far but no dice.

I fixed this by enabling developer setting in Windows, I had the same thing for days but this fixed it for me.

FrederoxDev commented 2 months ago

Sweet, good to hear, the latest release of the launcher should fully handle this now, so hopefully no more new users will run into this.