Refactor/use docker swarm

Fredkiss3 / gh-next

A minimal Github clone built on nextjs app router.

https://gh.fredkiss.dev/

MIT License

450 stars 21 forks source link

Refactor/use docker swarm #114

Closed Fredkiss3 closed 10 months ago

Fredkiss3 commented 11 months ago

Description

closes #112

Type of Change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

vercel[bot] commented 11 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
gh-next	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 22, 2023 1:57pm

Fredkiss3 commented 10 months ago

We might want to wait for this https://github.com/vercel/next.js/pull/59863 to merge this PR.

It fixes an issue with incremental-cache-handler-path & ESM

Fredkiss3 commented 10 months ago

We need to also add this :

from here : https://www.reddit.com/r/docker/comments/9ou9wx/comment/e7wwr9d/?utm_source=share&utm_medium=web2x&context=3

Just a quick note, docker cp requires a container but it does not need to be running, so basically I can do:

# Build my artifact as part of docker build

docker build

# Create but don't run container from resulting image

CID=$(docker create <image-name>)

# Grab that artifact sweetness

docker cp ${CID}:/path/to/artifacts /local/path/to/artifacts

# Container be gone

docker rm ${CID}