Fredkiss3 / gh-next

A minimal Github clone built on nextjs app router.
https://gh.fredkiss.dev/
MIT License
451 stars 21 forks source link

[♻️ refactor] Use `cmdk` for the action-list component #58

Open Fredkiss3 opened 1 year ago

Fredkiss3 commented 1 year ago

What is the reason to do this refactor ?.

To improve accessibility and navigation with keyboard on that component

Describe the work that needs to be done

Need to change the action-list input with cmdk input. And do the rest...

Additional context

We can tweak the use-item-grid hook i used here to do this and instead of passing every item group, we pass a function to get an item at a certain position in the list.

Fredkiss3 commented 1 year ago

won't do, too annoying