FredrikNoren / ungit

The easiest way to use git. On any platform. Anywhere.
MIT License
10.44k stars 637 forks source link

Remove ansi-color devDependency #1361

Closed Hirse closed 4 years ago

Hirse commented 4 years ago

The package is only used in one grunt task (parallel clicktests) to color output. Grunt can achieve similar coloring itself.

Additionally, when looking at the ansi-color npm and GitHub page I noticed that the license is not clearly Open Source, so we might be better off without this particular package even if we want something to color console output.

campersau commented 4 years ago

I am planning to move to npm scripts so this will be refactored to some standalone script where we don't have access to grunt.log. But since we only have two references to ansi-color we might just use the escape sequences directly:

https://stackoverflow.com/a/41407246

campersau commented 4 years ago

Superseded by #1370