search

FredrikNoren / ungit

The easiest way to use git. On any platform. Anywhere.
MIT License
10.44k stars 637 forks source link

move bumpdependencies to npm script #1371

Closed campersau closed 4 years ago

campersau commented 4 years ago

using https://www.npmjs.com/package/npm-check-updates part of https://github.com/FredrikNoren/ungit/issues/895

Hirse commented 4 years ago

Would it be possible to use the output of npm-check-updates for the PR body?

Since we are using version ranges, should we use ncu -m, --minimal?

do not upgrade to newer versions that are already satisfied by the existing version range

Alternatively, with this CI setup we could consider removing the ranges altogether and just use pinned versions.

campersau commented 4 years ago

Would it be possible to use the output of npm-check-updates for the PR body?

That was a bit challenging but it now looks like this: https://github.com/campersau/ungit/pull/6

Since we are using version ranges, should we use ncu -m, --minimal?

We were always bumping to the latest none prerelease version to also update the package-lock.json

Alternatively, with this CI setup we could consider removing the ranges altogether and just use pinned versions.

Yes, we could but there are third party integrations which might be affected by that?

Hirse commented 4 years ago

Output looks great. Thanks.