Closed campersau closed 4 years ago
I made a mistake in https://github.com/FredrikNoren/ungit/pull/1350 which prevented ungit from beeing loaded in electron. I assumend that fs.readdir(..., { withFileTypes: true }) would just work in electron but since we are using asar it apparently does not. See https://github.com/electron/electron/issues/19074
fs.readdir(..., { withFileTypes: true })
First commit refactors the code to the fs.readdir and fs.stat equivalent. The second commit gets rid of the directory check completely because we already catch and ignore all errors 😄
fs.readdir
fs.stat
I made a mistake in https://github.com/FredrikNoren/ungit/pull/1350 which prevented ungit from beeing loaded in electron. I assumend that
fs.readdir(..., { withFileTypes: true })would just work in electron but since we are using asar it apparently does not. See https://github.com/electron/electron/issues/19074First commit refactors the code to the
fs.readdirandfs.statequivalent. The second commit gets rid of the directory check completely because we already catch and ignore all errors 😄