FredrikNoren / ungit

The easiest way to use git. On any platform. Anywhere.
MIT License
10.41k stars 637 forks source link

ungit always oudated according to npm #1506

Closed LucaBlackDragon closed 2 years ago

LucaBlackDragon commented 2 years ago

If you run npm outdated, it will always show ungit as outaded:

❯ npm outdated --global
Package          Current  Wanted  Latest  Location            Depended by
ungit    1.5.19+e355698e  1.5.19  1.5.19  node_modules/ungit  global

Tested on Node 16.14.0, npm 8.5.2, Win10.

Apparently, the metadata portion +e355698e is fooling npm's ability to compare versions. Further elements to consider:

I think that on principle npm is wrong, it should recognise that 1.5.19+e355698e and 1.5.19 are equivalent (according to SemVer) and therefore it should not suggest that ungit needs to be updated. But to be more pragmatic, I would remove the metadata portion from the version and call it a day. What do you think?

LucaBlackDragon commented 2 years ago

issue solved with release 1.5.20, so I'm closing this