When killing the parent process, aka ungit, the child process, server.js, keeps running. This constitutes an issue in the context of editor extensions for instance, where closing the editor does not kill ungit's server, so running ungit then keeps saying "ungit already running".
It seems this might be related to #1537. I feel like their pull request uses a bit of a hacky workaround to the arguments issue, which is as far as I know, more of a yargs issue.
If it fixes the issue, I'd suggest coming back to using spawn and find another workaround for the former issue instead, if possible.
Edit: after testing, it seems Hirse's PR is not the issue
When killing the parent process, aka
ungit, the child process,server.js, keeps running. This constitutes an issue in the context of editor extensions for instance, where closing the editor does not kill ungit's server, so running ungit then keeps saying "ungit already running".It seems this might be related to #1537. I feel like their pull request uses a bit of a hacky workaround to the arguments issue, which is as far as I know, more of ayargsissue.If it fixes the issue, I'd suggest coming back to usingspawnand find another workaround for the former issue instead, if possible.Edit: after testing, it seems Hirse's PR is not the issue