search

FredrikNoren / ungit

The easiest way to use git. On any platform. Anywhere.
MIT License
10.44k stars 637 forks source link

Better handling of branch names containing a space #185

Closed zedutch closed 11 years ago

zedutch commented 11 years ago

I'm not sure if git allows branch names to contain spaces or not, but whenever I try to create a branch and name it something containing a space (e.g. "Foo Bar"), I get this page that says "Whooops Something went wrong, reload the page to start over." and I have to reload the page (sometimes multiple times). This is pretty annoying if I, by accident, forget that I can't use a space. If git allows branch names to contain whitespace characters, this is a bug in Ungit. If git does not allow that, I think Ungit should handle this case a little more user friendly... Saying what exactly went wrong would be a good start, for example. It would be even better if some kind of error could pop up to tell you that you can't do that, though.

FredrikNoren commented 11 years ago

Made a fix. It wont give you a nice error message though but rather just disables the button when there's spaces in the name, so it wont crash on you (for that reason :)