search

FredrikNoren / ungit

The easiest way to use git. On any platform. Anywhere.
MIT License
10.44k stars 637 forks source link

Scrolling disabled after push #199

Closed ylecuyer closed 10 years ago

FredrikNoren commented 11 years ago

Hm works for me. Browser? Ungit version?

ylecuyer commented 10 years ago

Ungit 0.2.0 Chromium Version 29.0.1547.65 (220622) Linux manjaro 3.4.61-1-MANJARO #1 SMP PREEMPT Sun Sep 8 11:27:14 UTC 2013 x86_64 GNU/Linux

FredrikNoren commented 10 years ago

Can you try to use the new contextual way of pushing? I.e. click the branch, then click the push button. Want to see if it's a problem with drag n drop

ylecuyer commented 10 years ago

Same thing the scrollbar disapeared

FredrikNoren commented 10 years ago

Really weird.. I'm kind of clueless. Does other operations also remove the scrollbar (checkout for instance)?

ylecuyer commented 10 years ago

No problems while doing checkout

FredrikNoren commented 10 years ago

Does it show you a credentials dialog when you push? Might be the dialog that messes something up. If you go to http://getbootstrap.com/javascript/#modals and click "Launch demo modal" and close it again does scrolling work then? (Ungit uses bootstrap for dialogs)

chribben commented 10 years ago

The problem is that the modal-open class, which is added by bootstrap on the body element as the modal dialog is displayed, isn't removed when the dialog is closed (which is the case in the bootstrap demo). In main.js there's an event handler for the hidden.bs.modal but I don't see why it should cause problems, it might however be worth investigating further.

FredrikNoren commented 10 years ago

@chribben Thanks for digging that up, easy fix when I knew what the problem was ;)

ylecuyer commented 10 years ago

@FredrikNoren Super thanks :+1:

gjolund commented 10 years ago

@FredrikNoren Awesome :+1: