search

FredrikNoren / ungit

The easiest way to use git. On any platform. Anywhere.
MIT License
10.44k stars 637 forks source link

dep cleanup #221

Closed jdalton closed 10 years ago

jdalton commented 10 years ago

I noticed ungit uses underscore for only _.last and _.find, many times including require('underscore') in a file and never using it.

Instead you could use individual packages for just last and find.

If you'd like a pull request just let me know.

FredrikNoren commented 10 years ago

Cool, sure feel free to post a pr, guess it could always scrape of a few ms from startup times! On 4 Oct 2013 07:19, "John-David Dalton" notifications@github.com wrote:

I noticed ungit uses underscore for only .last and .find, many times including require('underscore') in a file and never using it.

Instead you could use individual packages for just lasthttps://npmjs.org/package/lodash.lastand find https://npmjs.org/package/lodash.find.

If you'd like a pull request just let me know.

— Reply to this email directly or view it on GitHubhttps://github.com/FredrikNoren/ungit/issues/221 .

jdalton commented 10 years ago

Moved to #223.