FredrikNoren / ungit

The easiest way to use git. On any platform. Anywhere.
MIT License
10.45k stars 640 forks source link

BUG : Scroll position locks after github auth modal window closes #243

Closed gjolund closed 11 years ago

gjolund commented 11 years ago

After entering my github auth creds for remote auth the screen will lock at the current scroll position.

Only way I have found to resolve the issue is to reload the page, which will prompt another auth window and lock the scroll position at the top of the DOM.

I am running ungit on the nitrous.io cloud dev environment on a node.js box.

I can replicate the error by sharing my box url with you if you request it.

Client Error : screen shot 2013-10-16 at 1 48 06 pm

Server Log :

2013-10-16T20:41:07.602Z - info: emitting git-directory-changed to sockets, manually triggered                                                                                                                 
2013-10-16T20:41:07.638Z - info: GET /api/status?path=%2Fhome%2Faction%2Fworkspace%2Fiamhere-core&socketId=0                                                                                                   
2013-10-16T20:41:07.683Z - info: GET /api/log?path=%2Fhome%2Faction%2Fworkspace%2Fiamhere-core&limit=25&socketId=0                                                                                             
2013-10-16T20:41:07.687Z - info: GET /api/remotes?path=%2Fhome%2Faction%2Fworkspace%2Fiamhere-core&socketId=0                                                                                                  
2013-10-16T20:41:07.695Z - info: GET /api/checkout?path=%2Fhome%2Faction%2Fworkspace%2Fiamhere-core&socketId=0                                                                                                 
2013-10-16T20:42:16.233Z - info: GET /api/status?path=%2Fhome%2Faction%2Fworkspace%2Fiamhere-core&socketId=0                                                                                                   
2013-10-16T20:42:23.210Z - info: GET /api/status?path=%2Fhome%2Faction%2Fworkspace%2Fiamhere-core&socketId=0                                                                                                   
2013-10-16T20:42:34.803Z - info: GET /                                                                                                                                                                         
2013-10-16T20:42:35.109Z - info: transport end (socket end)                                                                                                                                                    
2013-10-16T20:42:35.111Z - info: Stop watching /home/action/workspace/iamhere-core                                                                                                                             
2013-10-16T20:42:35.142Z - info: GET /serverdata.js                                                                                                                                                            
2013-10-16T20:42:35.142Z - info: GET /css/styles.css                                                                                                                                                           
2013-10-16T20:42:35.145Z - info: GET /js/bugsense.js                                                                                                                                                           
2013-10-16T20:42:35.513Z - info: GET /js/ungit.js                                                                                                                                                              
2013-10-16T20:42:43.015Z - info: handshake authorized                                                                                                                                                          
2013-10-16T20:42:44.157Z - info: GET /images/logo.png                                                                                                                                                          
2013-10-16T20:42:44.162Z - info: GET /api/latestversion                                                                                                                                                        
2013-10-16T20:42:44.510Z - info: GET /api/quickstatus?path=%2Fhome%2Faction%2Fworkspace%2Fiamhere-core&socketId=1                                                                                              
2013-10-16T20:42:44.979Z - info: Start watching /home/action/workspace/iamhere-core                                                                                                                            
2013-10-16T20:42:44.987Z - info: GET /api/status?path=%2Fhome%2Faction%2Fworkspace%2Fiamhere-core&socketId=1                                                                                                   
2013-10-16T20:42:44.992Z - info: GET /api/log?path=%2Fhome%2Faction%2Fworkspace%2Fiamhere-core&limit=25&socketId=1                                                                                             
2013-10-16T20:42:44.992Z - info: GET /api/checkout?path=%2Fhome%2Faction%2Fworkspace%2Fiamhere-core&socketId=1                                                                                                 
2013-10-16T20:42:45.410Z - info: GET /api/remotes?path=%2Fhome%2Faction%2Fworkspace%2Fiamhere-core&socketId=1                                                                                                  
2013-10-16T20:42:46.019Z - info: GET /api/remote/tags?path=%2Fhome%2Faction%2Fworkspace%2Fiamhere-core&remote=origin&socketId=1                                                                                
2013-10-16T20:42:46.064Z - info: POST /api/fetch                                                                                                                                                               
2013-10-16T20:42:46.885Z - info: GET /api/credentials?socketId=1                                                                                                                                               
2013-10-16T20:42:46.975Z - info: GET /api/credentials?socketId=1                                                                                                                                               
2013-10-16T20:42:55.392Z - info: emitting git-directory-changed to sockets, manually triggered                                                                                                                 
2013-10-16T20:42:55.872Z - info: GET /api/status?path=%2Fhome%2Faction%2Fworkspace%2Fiamhere-core&socketId=1                                                                                                   
2013-10-16T20:42:55.926Z - info: GET /api/log?path=%2Fhome%2Faction%2Fworkspace%2Fiamhere-core&limit=25&socketId=1                                                                                             
2013-10-16T20:42:56.358Z - info: GET /api/checkout?path=%2Fhome%2Faction%2Fworkspace%2Fiamhere-core&socketId=1                                                                                                 
2013-10-16T20:42:56.360Z - info: GET /api/remotes?path=%2Fhome%2Faction%2Fworkspace%2Fiamhere-core&socketId=1                                                                                                  
2013-10-16T20:47:48.111Z - info: GET /api/status?path=%2Fhome%2Faction%2Fworkspace%2Fiamhere-core&socketId=1                                                                                                   
2013-10-16T20:48:14.272Z - info: GET /api/status?path=%2Fhome%2Faction%2Fworkspace%2Fiamhere-core&socketId=1                                                                                                   
2013-10-16T20:48:34.283Z - info: GET /api/status?path=%2Fhome%2Faction%2Fworkspace%2Fiamhere-core&socketId=1                                                                                                   
2013-10-16T20:48:46.684Z - info: GET /api/status?path=%2Fhome%2Faction%2Fworkspace%2Fiamhere-core&socketId=1 
FredrikNoren commented 11 years ago

Duplicate of #199. This has been fixed on master and will go out with the next release