Open cben opened 9 years ago
About the "bug report was sent", I see there is shouldSkipReport
logic to not send such reports;
then components/gitErrors/gitErrors.js respects it for showEnableBugtracking
but not for bugReportSent
.
(I'd send a PR to fix that but I'm following all the logic, specifically what's the distinction between ungit.config
and server.get('/userconfig',
...)
@cben ungit.config
is the "real" config. The other one is for modifying the config from the UI
Ungit fetches on startup, which fails when offline, filling the whole screen with detailed error messages (one from
fetch origin --prune
, another fromls-remote --tags origin
). It'd be nicer for beginners if it showed an "Offline" message instead of a scary error. (Especially since it's an error from an automatically initiated action.)Actually ungit already knows that's the issue, giving a hint "Couldn't reach remote repository, are you offline?". Perhaps such errors (and perhaps others with known hint?) should be shown collapsed, with just the hint but letting you access full details by clicking.
BTW, the error message also says "An automatic bug report was sent." which is slightly perplexing when one has no internet (as well as reinforces the error-on-startup impression that Ungit is somehow broken).
P.S. Thanks for Ungit, it's beautifully simple!