search

FredrikNoren / ungit

The easiest way to use git. On any platform. Anywhere.
MIT License
10.43k stars 637 forks source link

Using css animations #606

Open jung-kim opened 8 years ago

jung-kim commented 8 years ago

Currently, ungit does manual animation via js, edges and nodes.

It is my understanding that it would be much more efficient to do animations via css. As a none front end dv, I want to make sure if this is a good idea and there is no objections against it.

cc @FredrikNoren

FredrikNoren commented 8 years ago

Honestly I don't remember all of the specifics of how the animations are done. It might be worth a try, if it's possible to do I definitely agree it's preferable to js animations

nicolaiskogheim commented 8 years ago

I don't know much about this tool, but I know it's fast. It is as fast as CSS but should be much easier to work with.

Check it out if you've got the time: http://greensock.com/gsap

"Cage match" between GSAP and CSS: https://greensock.com/transitions/

jung-kim commented 8 years ago

So I haven't had good experiences with any softwares that offers both free version and licensed version at the same time, possible exception of intelliJ. Not only that, gsap or famo.us isn't too convincing unless one were to do elaborate animations to me.

Ajedi32 commented 8 years ago

I've heard that for some more complex animations, certain JS libraries can actually perform better than CSS by doing optimizations (like recycling existing objects) that native CSS animations can't do. (Can't find the article I read at the moment, but it was really interesting.)

For simple transitions though CSS is really, really easy to use (in fact, you can pretty much just ignore it in your JS code most of the time) and performs quite well.

jung-kim commented 8 years ago

My understanding is same as @Ajedi32 as well. I personally don't see ungit using advanced animations that would be excelled by these js libraries, I think it is a best to stick with css.