FredrikOseberg / react-chatbot-kit

MIT License
297 stars 139 forks source link

When I switch to 2.1.0_beta, parse() method cannot be invoked #106

Closed JeffRisberg closed 2 years ago

JeffRisberg commented 2 years ago

Recently tried the 2.1.0_beta branch.

I get the message "i.parse" is not a function. I appears that the API for the MessageParser component must have changed.

Do you have an example of using 2.1.0? I also want to use the payload facility, which appears to only be in 2.1.0

Thanks.

FredrikOseberg commented 2 years ago

Hi. This tag 2.1.0-beta.1 should still work in a backwards compatible manner. I have been working on building support for writing the MessageParser and ActionProvider as react components so you can use hooks.

JeffRisberg commented 2 years ago

I agree that it should, and the code in the tag seems correct. But I get:

react-dom.development.js:4091 Uncaught TypeError: i.parse is not a function
    at onSubmit (index.js:1:9562)
    at HTMLUnknownElement.callCallback (react-dom.development.js:3945:14)
    at Object.invokeGuardedCallbackDev (react-dom.development.js:3994:16)
    at invokeGuardedCallback (react-dom.development.js:4056:31)
    at invokeGuardedCallbackAndCatchFirstError (react-dom.development.js:4070:25)
    at executeDispatch (react-dom.development.js:8243:3)
    at processDispatchQueueItemsInOrder (react-dom.development.js:8275:7)
    at processDispatchQueue (react-dom.development.js:8288:5)
    at dispatchEventsForPlugins (react-dom.development.js:8299:3)
    at eval (react-dom.development.js:8508:12)

after I switch to the 2.1.0_beta.1 branch.

I will keep trying. Here is 'webpack info': webpack info

System: OS: macOS Mojave 10.14.6 CPU: (8) x64 Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz Memory: 4.37 GB / 16.00 GB Binaries: Node: 16.14.2 - /usr/local/bin/node Yarn: 3.2.0 - /usr/local/bin/yarn npm: 8.5.0 - /usr/local/bin/npm Browsers: Chrome: 100.0.4896.127 Safari: 14.1.2 Packages: babel-loader: ^8.2.4 => 8.2.4 css-loader: ^5.2.7 => 5.2.7 file-loader: ^6.0.0 => 6.2.0 react-hot-loader: ^4.13.0 => 4.13.0 sass-loader: ^12.6.0 => 12.6.0 style-loader: ^0.23.1 => 0.23.1 webpack: ^5.72.0 => 5.72.0 webpack-cli: ^4.9.2 => 4.9.2 Global Packages: webpack-cli: 4.9.2 webpack-dev-server: 2.11.5 webpack: 5.72.0

FredrikOseberg commented 2 years ago

Do you have your code somewhere publicly available?

On Wed, Apr 20, 2022 at 2:47 AM Jeff Risberg @.***> wrote:

I agree that it should, and the code in the tag seems correct. But I get:

react-dom.development.js:4091 Uncaught TypeError: i.parse is not a function at onSubmit (index.js:1:9562) at HTMLUnknownElement.callCallback (react-dom.development.js:3945:14) at Object.invokeGuardedCallbackDev (react-dom.development.js:3994:16) at invokeGuardedCallback (react-dom.development.js:4056:31) at invokeGuardedCallbackAndCatchFirstError (react-dom.development.js:4070:25) at executeDispatch (react-dom.development.js:8243:3) at processDispatchQueueItemsInOrder (react-dom.development.js:8275:7) at processDispatchQueue (react-dom.development.js:8288:5) at dispatchEventsForPlugins (react-dom.development.js:8299:3) at eval (react-dom.development.js:8508:12)

After switching to the 2.1.0_beta.1 branch. I will keep trying.

— Reply to this email directly, view it on GitHub https://github.com/FredrikOseberg/react-chatbot-kit/issues/106#issuecomment-1103309449, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD2WIPTY5M67WNNHK2CXDRTVF5H2XANCNFSM5TX7KXRQ . You are receiving this because you commented.Message ID: @.***>

JeffRisberg commented 2 years ago

yes, it is located in https://github.com/JeffRisberg/chatbot01 this code is largely the tutorial you provided, building the Learning Chatbot with LearningOptions and LinkedList components. Runs fine with 2.0.1, fails with 2.1.0-beta.1

FredrikOseberg commented 2 years ago

yes, it is located in https://github.com/JeffRisberg/chatbot01 this code is largely the tutorial you provided, building the Learning Chatbot with LearningOptions and LinkedList components. Runs fine with 2.0.1, fails with 2.1.0-beta.1

Curious. It seems to run fine when I start the app on my end: https://www.loom.com/share/7aed66989f1245a98f89798985cd3d79?focus_title=1&muted=1&from_recorder=1

JeffRisberg commented 2 years ago

I watched the video you submitted. In it, there was no call to messageParser.parse() that was succeeding. The only responses were the initial message, and clicking on the JavaScript button, which runs the actionHandler directly.

If you type "javascript" rather than clicking the button you will get the following screen shot: 2022-04-20_05-01-33

FredrikOseberg commented 2 years ago

Might be that the beta version is not up to date with the latest changes. Can you try this one: 2.1.0-beta.2 ?

JeffRisberg commented 2 years ago

Thanks, that worked!

All message parsing and action handling functions are working as in 2.0.1. Now I will start working with the message payload facility. There isn't documentation, but I can see how you have added field(s) to the message data record, and how this is passed to the rendering of the widgets.

Much appreciated.

FredrikOseberg commented 2 years ago

Thanks, that worked!

All message parsing and action handling functions are working as in 2.0.1. Now I will start working with the message payload facility. There isn't documentation, but I can see how you have added field(s) to the message data record, and how this is passed to the rendering of the widgets.

Much appreciated.

Awesome! Thanks for reminding me of this, the docs are undergoing some revamp due to the rewrite. I've been postponing it, but seeing as it's basically ready to go I need to get it out soon :)