search

FredrikOseberg / react-chatbot-kit

MIT License
299 stars 139 forks source link

Webpack version issue #51

Open jamesmart77 opened 3 years ago

jamesmart77 commented 3 years ago

Hey Fredrick,

Super cool library and very easy to use - well done!

Issue Summary This library has a dependency on your other library, react-util-kit. In that library, the package.json has the webpack version hardcoded to version 4.23.1 and the devDependency webpack version you have in the react-chatbot-kit is at 4.42.0.

These different webpack versions are causing some build issues for our team as this dependency tree check causes the preflight check to fail.

Can you update your react-util-kit webpack version to be equal to this library, please?

FredrikOseberg commented 3 years ago

Hi, and thank you!

I'm deprecating react-util-kit in favor of https://github.com/FredrikOseberg/react-conditionally-render. This fix should be included in an impending 2.0 release of this library. How urgent is this fix for your side?

jamesmart77 commented 3 years ago

Thanks for the quick update. We have gotten our builds to pass with SKIP_PREFLIGHT_CHECK=true. Although not ideal, it's a fine short-term solution until version 2.0 release is ready.

Just so we can keep an eye out, is there a time frame you're aiming at for this new release?

FredrikOseberg commented 3 years ago

Thanks for the quick update. We have gotten our builds to pass with SKIP_PREFLIGHT_CHECK=true. Although not ideal, it's a fine short-term solution until version 2.0 release is ready.

Just so we can keep an eye out, is there a time frame you're aiming at for this new release?

No worries. I haven't put it on a strict time schedule but I aim to have it done by end of May.

jamesmart77 commented 3 years ago

Great, thanks! Can you follow up on this ticket once the new release is available?