FredsFactory / FreeCAD_AirPlaneDesign

FreeCAD WorkBench Air Plane Design
GNU Lesser General Public License v2.1
79 stars 14 forks source link

Fix bug preventing recompute on ribs generated from dat file + minor improvements #26

Closed adrianinsaval closed 4 years ago

adrianinsaval commented 4 years ago

Please review the code, on he first commit the half_cosine_spacing parameter is passed as True by default, producing a much smoother LE in NACA profiles with fewer points, the following is a comparison using 100 instead of the default 240 points: new vs old green:half_cosine_spacing=True red: half_cosine_spacing=False

on second commit the Geometry property wich was of type Part::PropertyGeometryList was replaced with the new Coordinates property of type App::PropertyVectorList. This is compatible with the coords variable used throughout the code so this is the variable that is stored instead of the ambiguous geometry variable.

The last commit just removes unnecesary colons and imports and follows a recommendation I've read on the FreeCAD forums: don't import specific functions from FreeCAD as it can be confusing, using FreeCAD.Vector and such makes it clear that it is a function from FreeCAD itself, I can't find the post at the moment but it was a tip from a developer.