search

FredyH / MySQLOO

MySQLOO
GNU Lesser General Public License v2.1
140 stars 55 forks source link

Update the project against MySQL v8.0 #20

Closed kklouzal closed 6 years ago

kklouzal commented 6 years ago

MySQL version 8.0 has been released and offers major performance and security upgrades.

Will the project be updated against this new version?

FredyH commented 6 years ago

the current module should work just fine with mysql 8,0. Are there any features that are new and you want added?

monster010 commented 6 years ago

a fix for Error - no MetaName string type for userdata (AGH!) Error - no MetaName string type for userdata (AGH!) Error - no MetaName string type for userdata (AGH!) Error - no MetaName string type for userdata (AGH!) Error - no MetaName string type for userdata (AGH!) Error - no MetaName string type for userdata (AGH!) Error - no MetaName string type for userdata (AGH!) Error - no MetaName string type for userdata (AGH!) Error - no MetaName string type for userdata (AGH!) Error - no MetaName string type for userdata (AGH!) Error - no MetaName string type for userdata (AGH!) Error - no MetaName string type for userdata (AGH!) Error - no MetaName string type for userdata (AGH!) Error - no MetaName string type for userdata (AGH!) Error - no MetaName string type for userdata (AGH!) Error - no MetaName string type for userdata (AGH!) Error - no MetaName string type for userdata (AGH!) Error - no MetaName string type for userdata (AGH!) Error - no MetaName string type for userdata (AGH!) Error - no MetaName string type for userdata (AGH!) Error - no MetaName string type for userdata (AGH!) Error - no MetaName string type for userdata (AGH!) Error - no MetaName string type for userdata (AGH!) Error - no MetaName string type for userdata (AGH!) Error - no MetaName string type for userdata (AGH!)

would be nice

FredyH commented 6 years ago

Is this related to mysql8? Please post some steps to reproduce

monster010 commented 6 years ago

Quite simple: Just install PointShop 2, let players buy things and wait for a map change, then the error is about 90000 in the log.

I am not sure if it comes directly from mysql or if it comes from Pointshop. Think but rather mysql, as in the Pointshop or LibK Code this error message does not exist.

FredyH commented 6 years ago

It seems like pointshop is printing something that it really shouldn't, have you contacted the devs of pointshop yet?

monster010 commented 6 years ago

Yes, I have notified him

ValentinFunk commented 6 years ago

It's not the shop printing it @FredyH, i believe it's printed by gmod and it happens when using MySQLOO. Don't have anything more specific but it has been around since before there was a pointshop (https://gmod.facepunch.com/f/gmoddev/nkvn/Mysql-related-No-MetaName-string-type-for-userdata-AGH/1/)

ValentinFunk commented 6 years ago

If it helps at all this is how all queries are created: https://github.com/Kamshak/LibK/blob/master/lua/libk/server/sv_libk_database.lua#L113

It's derived from how DarkRP used to do it. The queries can end up being fairly long when they are generated (not sure if this could be related)

kklouzal commented 6 years ago

I'm having an issue where I'll try to submit a specific query multiple times with no response. mysqloo does not call onError() nor onSuccess(). Something happens after calling send() that stops the query from completing.

It seemed to start happening after I upgraded to version 8.0 but that may just be a coincidence.

ValentinFunk commented 6 years ago

The console error spam should be gone in the next gmod version https://github.com/Facepunch/garrysmod-issues/issues/3452

FredyH commented 6 years ago

@kklouzal can you post an example of when/how this happens?

kklouzal commented 6 years ago

Sorry I switched over to using procedures and this solved the problem. I would still suggest updating the library against mysql version 8.0 i would like to connect to my database using the new security encryption and if any performance enhancements or bug fixes have been included in the new 8.0 release that's always a bonus.