codecov[bot]
commented
4 years ago Codecov Report
Merging #54 into master will decrease coverage by
0.38%. The diff coverage is60.00%.
@@ Coverage Diff @@
## master #54 +/- ##
==========================================
- Coverage 72.18% 71.80% -0.39%
==========================================
Files 21 21
Lines 604 610 +6
Branches 61 61
==========================================
+ Hits 436 438 +2
- Misses 164 168 +4
Partials 4 4 | Impacted Files | Coverage Δ | |
|---|---|---|
| CyborgianStates/Program.cs | 92.30% <60.00%> (-7.70%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 5d4ad61...b96aed6. Read the comment docs.
Description
When starting the bot with the default config it just failed silently. Now the main method catches such fatal exceptions and write them to the Standard Error Output Stream.
Motivation and Context
The main method called
Launcher.RunAsync()in a sync way. That caused the call to silently fail if a exception occured. Resulting in a crash of the bot.Fixes: #50
This can be further improved by using actual logging and config checking for more concise error mesages before calling
Launcher.RunAsync()How Has This Been Tested?
Manually
Types of changes
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
Checklist:
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] I have read the CONTRIBUTING document.