Free-Nations-Region / CyborgianStates

A (Discord-) Bot for all needs of a Region in NationStates
MIT License
0 stars 1 forks source link

Improve Nation Command #72

Closed drehtisch closed 3 years ago

drehtisch commented 3 years ago

Motivation and Context

Closes #70

How Has This Been Tested?

Manually on Discord, Console + UnitTests

Types of changes

Checklist:

codecov[bot] commented 3 years ago

Codecov Report

Merging #72 (ce1baa7) into Rel4.0 (69cd8e1) will increase coverage by 0.16%. The diff coverage is 96.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           Rel4.0      #72      +/-   ##
==========================================
+ Coverage   98.41%   98.57%   +0.16%     
==========================================
  Files          30       30              
  Lines        1197     1266      +69     
  Branches      130      139       +9     
==========================================
+ Hits         1178     1248      +70     
+ Misses          6        3       -3     
- Partials       13       15       +2     
Impacted Files Coverage Δ
...es/CommandHandling/NationStatesApiRequestWorker.cs 93.75% <85.71%> (+1.44%) :arrow_up:
CyborgianStates/Commands/NationStatsCommand.cs 96.71% <96.29%> (+2.06%) :arrow_up:
CyborgianStates/Interfaces/IResponseBuilder.cs 100.00% <100.00%> (ø)
...rgianStates/MessageHandling/BaseResponseBuilder.cs 100.00% <100.00%> (ø)
.../MessageHandling/Discord/DiscordResponseBuilder.cs 100.00% <100.00%> (ø)
...rgianStates/Services/NationStatesApiDataService.cs 96.42% <100.00%> (-0.80%) :arrow_down:
CyborgianStates/CommandHandling/Request.cs 100.00% <0.00%> (+1.78%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 69cd8e1...ce1baa7. Read the comment docs.