codecov[bot]
commented
2 years ago Codecov Report
Attention: 154 lines in your changes are missing coverage. Please review.
Comparison is base (
2161f89) 71.45% compared to head (b56f4b9) 68.09%. Report is 1 commits behind head on main.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #81 +/- ## ========================================== - Coverage 71.45% 68.09% -3.37% ========================================== Files 28 29 +1 Lines 1482 1586 +104 Branches 157 170 +13 ========================================== + Hits 1059 1080 +21 - Misses 386 470 +84 + Partials 37 36 -1 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
This pull request implements the couldendorse (ce) command from issue #60.
Motivation and Context
This command existed in the NationStatesAPIBot currently in use by the FNR Discord and is of frequent usage. It allows us to view all the nations we have not yet endorsed.
This pull request should close issue #60.
How Has This Been Tested?
I used both the console and separate Discord bot for testing. I ran the
$ce <NATION>command until I was satisfied. I tested nations that are not WA members, nations that have just a few missing endorsements, and nations with many missing endorsements (to trigger split embeds.)I did not write any unit tests.
There is an attempt to fix the
BaseResponseBuilder. The solution does not seem to work entirely, but is a step in the right direction. A new issue will be created.Screenshots (if appropriate):
Types of changes
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
Checklist:
[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[ ] I have read the CONTRIBUTING document.