Free-Nations-Region / CyborgianStates

A (Discord-) Bot for all needs of a Region in NationStates
MIT License
0 stars 1 forks source link

Fix #82: ResponseBuilder doesn't clear properly #83

Closed drehtisch closed 1 year ago

drehtisch commented 2 years ago

Description

Ensure that ResponseBuilder (especially DiscordResponseBuilder) gets cleared properly when Clear() gets called.

Motivation and Context

Fixes #82

How Has This Been Tested?

Unit tests

Types of changes

Checklist:

codecov[bot] commented 2 years ago

Codecov Report

Merging #83 (3ce1ec3) into main (b6f5e92) will increase coverage by 0.27%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #83      +/-   ##
==========================================
+ Coverage   75.91%   76.18%   +0.27%     
==========================================
  Files          29       29              
  Lines        1345     1348       +3     
  Branches      140      140              
==========================================
+ Hits         1021     1027       +6     
+ Misses        286      283       -3     
  Partials       38       38              
Impacted Files Coverage Δ
...rgianStates/MessageHandling/BaseResponseBuilder.cs 91.42% <100.00%> (+0.25%) :arrow_up:
.../MessageHandling/Discord/DiscordResponseBuilder.cs 100.00% <100.00%> (ø)
...s/MessageHandling/Discord/DiscordMessageHandler.cs 94.89% <0.00%> (+3.06%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b6f5e92...3ce1ec3. Read the comment docs.