search

FreeAllMedia / stimpak

An easy-to-use system for defining, discovering, and re-using code, text, and workflow patterns
http://stimpak.io
MIT License
8 stars 1 forks source link

Replaced fileSystem moving around with requireg #5

Closed warang580 closed 8 years ago

warang580 commented 8 years ago

Remove the need for moving generators (especially globally installed generators) into a temporary directory before require()-ing.

I simplified stimpak using requireg. All tests are at green !

Note: In source/spec/cli/stimpak.cli.helper.js, I replaced temporaryNodeModulesDirectoryPath with globalNodeModulesDirectoryPath because, as I understand it, generators need to be installed globally and they would be installed in the global directory, not in the temporary one (they were not found with requireg in the last one).

I think it covers every point you wanted, but check source/spec/cli/stimpak.cli.helper.js to be sure I did a correct change.

warang580 commented 8 years ago

Travis-CI fails on Node.js v0.10 version because child_process.execSync doesn't exist (yet).

dcrockwell commented 8 years ago

Don't worry about the 0.10, we'll take care of that in another PR.

I'm checking over the code now :)

dcrockwell commented 8 years ago

You probably want to pull from the latest develop now to avoid merge nightmares later

dcrockwell commented 8 years ago

You need to see this. It kind of changes everything and invalidates the work in this PR: https://github.com/FreeAllMedia/stimpak/issues/13