search

FreeAndFair / ColoradoRLA

Software to facilitate risk-limiting audits at the state level, developed for the state of Colorado.
Other
21 stars 8 forks source link

Modify license line in almost all server files #906

Closed sfsinger19103 closed 6 years ago

nealmcb commented 6 years ago

Hmmm - don't we want to mention the license in the files somewhere? Just take out the "Classpath" part? Let me review what Chris advised.

nealmcb commented 6 years ago

See e.g. https://github.com/FreeAndFair/ColoradoRLA/pull/884#issuecomment-346979966 where Chris notes that FSF advises putting a (briefer) license notice near the top of each file.

https://www.gnu.org/licenses/gpl-howto.html

Put a license notice in each file.

nealmcb commented 6 years ago

If a new version of AGPL comes out, should we be able to use it? I like to trust FSF and guess a fix might be important some day. But suppose some horrid takeover could take place.... Given the large project and sometimes confusing licensing, SPDX seems useful to me.

I.e., should we say

@license SPDX-License-Identifier: AGPL-3.0-only or this @license SPDX-License-Identifier: AGPL-3.0-or-later

sfsinger19103 commented 6 years ago

I don't know.

kiniry commented 6 years ago

I'm just now seeing this discussion while I was working on something else and then rebasing this.

kiniry commented 6 years ago

@ranweiler We need a license declaration in every file you wrote in the front-end too.

ranweiler commented 6 years ago

@kiniry ack. I can add that this weekend.

nealmcb commented 6 years ago

I think we can either include the client license line changes or not with this PR. Other changes still needed are listed in #899