FreeAndFair / OpenRLA

Free & Fair's open source RLA support software.
Other
4 stars 3 forks source link

Major style and layout improvements #70

Closed ranweiler closed 7 years ago

ranweiler commented 7 years ago

For #47, #9.

Todo

Comments

For a first pass, we are going to use "inline styles". This means that we pass a style prop to style particular component root elements. Our styles are thus defined in code, and there is no built-in cascading. This is dead-simple, and is the original API for styling material-ui components.

This is, however, possibly less designer-friendly, the material-ui project is moving away from it, and it can be suboptimal w.r.t. performance. In the long-term, we should instead set the className prop for components, using whatever CSS scheme the design team prefers (e.g. BEM). We can then just use a stylesheet like usual (which we already include).

For now, this approach allows us to make narrow adjustments at the cost of a bit of extra typing. Other future alternatives include making custom "generic" components (wrappers around the material-ui components) which set styles in the way we prefer.