search

FreeBSDDesktop / DEPRECATED-freebsd-base-graphics

Fork of FreeBSD's base repository to work on graphics-stack-related projects
Other
49 stars 13 forks source link

Artifacts on MacBookPro 2015 again #34

Closed huanghwh closed 8 years ago

huanghwh commented 8 years ago

Update to the latest, Got artifacts again. About week ago, no this problem. img_1785

mattmacy commented 8 years ago

Are you running the latest xf86-video-intel per the wiki?

huanghwh commented 8 years ago

No, I am running xf86-video-intel from ports.

mattmacy commented 8 years ago

That's 3 or 4 years old. You need to either build newer from the xserver-next branch in: https://github.com/freebsd/freebsd-ports-graphics

I've built a bunch of up to date packages here: http://www.bsddesktop.com/images/xserver-next-pkgs/

huanghwh commented 8 years ago

After update to xserver-next-pkgs, got this error: img_1787

mattmacy commented 8 years ago

maybe you can bisect back to the change that introduced artifacts?

huanghwh commented 8 years ago

The version "fc26d6b" is good, and the version "ac46418" introduced artifacts.

mattmacy commented 8 years ago

Thanks.

mattmacy commented 8 years ago

https://github.com/FreeBSDDesktop/freebsd-base-graphics/commit/1dd30c600a765c60e59e9caebb36677ecb192ff3 should add a new tunable / sysctl for you to disable write combining mmap. I'm not reverting the code because it should work and I want to understand why it causes problems. But this knob will allow you to turn it off.

huanghwh commented 8 years ago

I should be mentioned that I still use xf86-video-intel from ports as xf86-video-intel from xserver-next-pkgs caused GPU hang. I set dev.drm.skipwc=1, still got this, artifacts in menu item: img_1798

mattmacy commented 8 years ago

Please let me know how the latest changes behave for you. They fix artifacts on some systems.

mattmacy commented 8 years ago

On second thought I should probably not have committed so soon.

huanghwh commented 8 years ago

Unfortunately, with 4059f9b, still got the artifacts in the mate system menu item.

mattmacy commented 8 years ago

I've disabled the MMAP_WC change for now. Does it bring it back to normal for you?

huanghwh commented 8 years ago

No，with ecd31fb still got the artifacts in the mate system menu item.

mattmacy commented 8 years ago

Then that change must not have introduced the artifacts. Can you check again?

huanghwh commented 8 years ago

OK, I will double-check it soon...

huanghwh commented 8 years ago

I had checked again,same result: image image

huanghwh commented 8 years ago

The artifacts is gone after I disable these code:

/ if (args->flags & ~(I915_MMAP_WC)) { DRM_DEBUG("Attempting to mmap with flag other than WC set\n"); return -EINVAL; } if (args->flags & I915_MMAP_WC && !cpu_has_pat) { DRM_DEBUG("Attempting to mmap WC without pat\n"); return -ENODEV; } /

huanghwh commented 8 years ago

"de6c000" fixed my problem.