search

FreeBSDDesktop / kms-drm

the DRM part of the linuxkpi-based KMS
63 stars 26 forks source link

drm/amdgpu/psp: ignore psp response status #234

Closed avg-I closed 4 years ago

avg-I commented 4 years ago

This PR picks up two upstream commits. On my hardware both Linux (5.3.x) and FreeBSD amdgpu drivers report similar errors:

[    6.603437] [drm] failed to load ucode id (12) 
[    6.603440] [drm] psp command failed and response status is (-53233)
[    6.619445] [drm] failed to load ucode id (13) 
[    6.619446] [drm] psp command failed and response status is (-65521)
[    6.631459] [drm] failed to load ucode id (14) 
[    6.631462] [drm] psp command failed and response status is (-65521)
[drm ERROR :psp_cmd_submit_buf] failed loading with status (-53233) and ucode id (10)
[drm ERROR :psp_hw_init] PSP firmware loading failed
[drm ERROR :amdgpu_device_fw_loading] hw_init of IP block <psp> failed -22
drmn0: amdgpu_device_ip_init failed
drmn0: Fatal error during GPU init

The obvious difference is that on Linux the error is not fatal while on FreeBSD it was. After the change, FreeBSD amdgpu is able to attach successfully:

[drm] failed to load ucode id (10) <4>[drm] psp command failed and response status is (-53233)
[drm] failed to load ucode id (11) <4>[drm] psp command failed and response status is (-65521)
[drm] failed to load ucode id (12) <4>[drm] psp command failed and response status is (-65521)
avg-I commented 4 years ago

I picked up two commits for the sake of a conflict-free merge.