search

FreeCAD / DevelopersHandbook

A handbook about FreeCAD development
47 stars 30 forks source link

Try to fix .pre-commit-config.yaml so check do not fail #77

Closed marcuspollio closed 1 year ago

marcuspollio commented 1 year ago

Hi there ! I tried to run locally pre-commit but it seemed it could not access markdownlint. After adding the Hypertext Transfer Protocol Secure to the Github repo it looks ok on my side:

pre-commit

What do you think ?

marcuspollio commented 1 year ago

So, compared to my previous PR where the pre-commit CI could not pass the build stage, it is now stuck at the Markdownlint check... =D

Any idea how to proceed next ? XD

chennes commented 1 year ago

I'd just eliminate that check for the time being: we need to manually fix the issues before we can re-enable.

marcuspollio commented 1 year ago

Not sure I understood what you mean ?

Is it ok if I comment out the hooks lines for markdownlint ?

Edit: looks ok for now. I added a note to re-enable.

@chennes What kind of issues are you referring to ?