FreeCAD / FreeCAD-Bundle

Stand-alone repo to Build and Deploy installable FreeCAD images
https://freecad.org
GNU Lesser General Public License v2.1
224 stars 58 forks source link

Fix AppImage Icons for Freecad Stable #182

Closed leoheck closed 11 months ago

leoheck commented 1 year ago

Hi, recently we fixed the main Icon of the AppImage for the Freecad Weekly. Now it is time to do the same for the stable version.

Here is the PR that fixed the icons of the Freecad Weekly, https://github.com/FreeCAD/FreeCAD-Bundle/pull/98 as a reference.

I have both the latest weekly build 0.21 and the current 0.20.2 stable version installed. The full version of the stable installed can be seen at the end of this message.

As you can see in the following screenshot, the Icon Launcher does not have an image and also does not have the right or right text/label/description.

image

And here is its full .desktop file, for reference:

[Desktop Entry]
Version=1.0
Name=FreeCAD Weekly (4)
Exec=/home/lheck/Applications/FreeCAD_0.20.2-2022-12-27-conda-Linux-x86_64-py310_529d628153ed2b233333ba5cef519383.AppImage
Icon=appimagekit_1f2dfb10509ef4416c08e6f11adda79a_freecad_weekly
Type=Application
Categories=Engineering;
Comment=Feature based Parametric Modeler
Terminal=false
StartupNotify=true
NoDisplay=false
MimeType=application/x-extension-fcstd;

TryExec=/home/lheck/Applications/FreeCAD_0.20.2-2022-12-27-conda-Linux-x86_64-py310_529d628153ed2b233333ba5cef519383.AppImage
X-AppImage-Old-Icon=freecad_weekly
X-AppImage-Identifier=1f2dfb10509ef4416c08e6f11adda79a
Actions=Remove;Update;
X-AppImageLauncher-Version=2.2.0 (git commit 0f91801), built on 2020-09-29 21:36:15 UTC

[Desktop Action Remove]
Name=Remove AppImage from system
Icon=AppImageLauncher
Exec=/usr/lib/x86_64-linux-gnu/appimagelauncher/remove "/home/lheck/Applications/FreeCAD_0.20.2-2022-12-27-conda-Linux-x86_64-py310_529d628153ed2b233333ba5cef519383.AppImage"
Name[ast]=Desaniciar AppImage del sistema
Name[cs]=Odebrat AppImage ze systému
Name[de]=AppImage vom System entfernen
Name[en]=Remove AppImage from system
Name[es]=Eliminar Appimage del Sistema
Name[fr]=Supprimer l'AppImage du système
Name[it]=Rimuovi AppImage dal sistema
Name[nl]=AppImage deïnstalleren
Name[pl]=Usuń AppImage z systemu
Name[pt]=Remover AppImage do sistema
Name[pt_PT]=Remover AppImage do sistema
Name[ru]=Удалить AppImage из системы
Name[zh_Hans]=从系统中移除 AppImage

[Desktop Action Update]
Name=Update AppImage
Icon=AppImageLauncher
Exec=/usr/lib/x86_64-linux-gnu/appimagelauncher/update "/home/lheck/Applications/FreeCAD_0.20.2-2022-12-27-conda-Linux-x86_64-py310_529d628153ed2b233333ba5cef519383.AppImage"
Name[ast]=Anovar AppImage
Name[cs]=Aktualizovat AppImage
Name[de]=AppImage aktualisieren
Name[en]=Update AppImage
Name[es]=Actualizar Appimage
Name[fr]=Mettre à jour l'AppImage
Name[it]=Aggiorna AppImage
Name[nl]=AppImage bijwerken
Name[pl]=Uaktualnij AppImage
Name[pt]=Actualizar AppImage
Name[pt_PT]=Atualizar AppImage
Name[ru]=Обновить AppImage
Name[zh_Hans]=更新 AppImage
OS: Ubuntu 23.04 (ubuntu:GNOME/ubuntu-xorg)
Word size of FreeCAD: 64-bit
Version: 0.20.2.29603 (Git) AppImage
Build type: Release
Branch: (HEAD detached at 0.20.2)
Hash: 930dd9a76203a3260b1e6256c70c1c3cad8c5cb8
Python 3.10.8, Qt 5.15.4, Coin 4.0.0, Vtk 9.1.0, OCC 7.6.3
Locale: English/United States (en_US)
Installed mods: 
  * Defeaturing 1.2.0
  * Curves 0.6.9
  * fasteners 0.4.56
  * lattice2 1.0.0
  * freecad.gears 1.0.0
  * sheetmetal 0.2.63
  * Assembly4 0.50.2
  * kicadStepUpMod 10.19.4
  * ProDarkThemePreferencePack 1.0.0
  * Help 1.0.3
leoheck commented 1 year ago

PR, https://github.com/FreeCAD/FreeCAD-Bundle/pull/183 I guest it is all that is needed since the Weekly version is already working. If this PR is ok, and the fix is merged, then it should be interesting to rebuild the AppImage of the latest version of Freecad, at least.

leoheck commented 11 months ago

The Name of the current launcher is wrong still. It could be something like FreeCAD 0.21. I am seeing this: image