search

FreeCAD / FreeCAD-Homepage

The homepage at http://www.freecad.org
GNU Lesser General Public License v2.1
26 stars 42 forks source link

Added Error 404 page. #123

Closed AdarshRawat1 closed 1 year ago

AdarshRawat1 commented 1 year ago

Closes #121 In the event of a 404 error, a customized error 404 page will be displayed.

Please share your ideas on how to improve the image on the error 404 page here

image

Edit Check the live changes here - https://www.freecad.org/no_such_page.html

The final webpage after recommendations on PR -
image

chennes commented 1 year ago

I'm not thrilled with the diagrams.net SVG with all the embedded binary data. Can we make something simpler in Inkscape instead?

AdarshRawat1 commented 1 year ago

Noted ! Will update it . Any suggestions on what image should be used?

yorikvanhavre commented 1 year ago

Honestly I'd either reuse the current image, or use a "error" icon (make sure you use one with an open license). Maybe there is a suitable icon in FreeCAD itself? https://github.com/FreeCAD/FreeCAD/tree/master/src/Gui/Icons

AdarshRawat1 commented 1 year ago

@yorikvanhavre I will review the existing icons in FreeCAD and select the most suitable one for the error page.

AdarshRawat1 commented 1 year ago

@chennes @yorikvanhavre please check the icon. image

chennes commented 1 year ago

I think this is a good improvement over what we had. If one of our resident graphics designers wants to give it a look later on, more power to them. Thanks for the PR!

chennes commented 1 year ago

Oh, but I wasn't thinking about it... we're on nginx, it doesn't use the .htaccess settings. I've edited the nginx config to use the new file, it seems to be working: https://www.freecad.org/no_such_page.html