search

FreeCAD / FreeCAD-addons

A convenient gathering of useful and well-developed FreeCAD plugins made by the community.
769 stars 253 forks source link

Add OSAFE workbench #259

Closed ebrahimraeyat closed 1 year ago

ebrahimraeyat commented 1 year ago

Related issue

luzpaz commented 1 year ago

Thanks, we made the issue template for adding a workbench for this reason

Screenshot_20230531_082037

Do you mind filling it out? (https://github.com/FreeCAD/FreeCAD-addons/issues/new/choose)

luzpaz commented 1 year ago

@ebrahimraeyat please follow-up thx

ebrahimraeyat commented 1 year ago

Thanks @luzpaz . Related issue

chennes commented 1 year ago

This looks OK to me, if it's OK with @luzpaz . Please note that we will likely switch to compiling FreeCAD against Qt6 as our main version in the coming months, so you'll want to consider supporting that version (for the most part that will involve using import PySide instead of import PySide2, and letting FreeCAD insert the correct version at runtime).

ebrahimraeyat commented 1 year ago

I will change the import note, thanks @chennes .

ebrahimraeyat commented 1 year ago

I examined. It is not compatible with FreeCAD 0.19, I will try to release a new version based on FreeCAD 0.21. I prepared it, but I can't compress the final output compiled, it take 800 MB size. Can I continue this problem in this issue? or in forum? Thanks.

chennes commented 1 year ago

Sure, wherever you like. I don't consider this a blocking issue here (unless you do).