FreeCAD / FreeCAD-addons

A convenient gathering of useful and well-developed FreeCAD plugins made by the community.
769 stars 253 forks source link

[New Addon/Workbench] OpenDark preference pack #278

Closed obelisk79 closed 1 year ago

obelisk79 commented 1 year ago

I would like my Preference Pack "OpenDark" added to the manager. I have verified the repo works with addon-manager as a custom source.

https://github.com/obelisk79/OpenDark/

image

Dependencies

README.md

Misc.

Housekeeping

Github Related

Note: if your addon/workbench code doesn't reside on Github, please state the address where it is mentioned

PaddleStroke commented 1 year ago

You perhaps want to set the type to theme so that it appears inside the theme combobox ?

obelisk79 commented 1 year ago

You perhaps want to set the type to theme so that it appears inside the theme combobox ?

I'm not sure how to do that, I didn't see it documented on the wiki.

PaddleStroke commented 1 year ago

Just add <type>Theme</type> to the preferencepack in the xml

<?xml version="1.0" encoding="UTF-8" standalone="no" ?>
<package format="1" xmlns="https://wiki.freecad.org/Package_Metadata">
 <name>OpenDark</name>
 <version>2023.09.27b</version>
 <date>2023.09.27</date>
 <description>An accessible and coordinated Dark theme for FreeCAD</description>
 <maintainer email="nomail@freecad.org">Obelisk79</maintainer>
 <license file="LICENSE">GPLv3</license>
 <url type="repository" branch="main">https://github.com/obelisk79/OpenDark</url>
 <icon>resources/icons/OpenDark.svg</icon>

<content>
  <preferencepack>
    <name>OpenDark</name>
    <type>Theme</type>
    <description>An accessible and coordinated Dark theme for FreeCAD based on the wonderful Open-Color ui palette</description>
    <tag>2023</tag>
    <tag>theme</tag>
    <tag>dark</tag>
    <file>OpenDark.qss</file>
  </preferencepack>
  <workbench>
    <name>QtNormalizer</name>
    <description>Sets Qt Widget visual style to normalize appearance across disparate compute r platforms</description>
    <classname>QtNormalizer</classname>
  </workbench>
</content>
</package>
obelisk79 commented 1 year ago

I added that line, but it didn't remove the pref pack from the list and add it to the theme dropdown as it should.

luzpaz commented 1 year ago

Issue with license: https://github.com/obelisk79/OpenDark/issues/4

obelisk79 commented 1 year ago

Thank you for pointing that out. I've made the necessary correction. This has been an educational experience :)

luzpaz commented 1 year ago

@chennes I've given feedback and changes have been implemented. i'll leave it to you to pull the trigger to add to the Addon repo.

chennes commented 1 year ago

https://github.com/FreeCAD/FreeCAD-addons/pull/279

luzpaz commented 1 year ago

Congrats @obelisk79! Thank you for your contribution. Thanks chennes for the assist.