[CenterOfMass] s-quirin redesign

FreeCAD / FreeCAD-macros

A repository for FreeCAD macros

https://freecad.org/wiki/Macros_recipes

145 stars 134 forks source link

[CenterOfMass] s-quirin redesign #126

Closed chupins closed 2 years ago

chupins commented 2 years ago

[x] Please check this box if you're not submitting a new macro.

s-quirin completly redesign the macro (and gives it a lot of improvments)

luzpaz commented 2 years ago

Is there a forum thread associated with the redesign?

chupins commented 2 years ago

Yes, it's presented at the end of the original macro thread : https://forum.freecadweb.org/viewtopic.php?p=578665#p578665

s-quirin commented 2 years ago

Thank you @galou for the in depth analysis, I start looking into it. Is the "change" of author remarked in the forum an issue? It should be consistent to use Github or Forum User name. @chupins How do you like it?

galou commented 2 years ago

No problem with the change in author name. Just keep one name per author.

chupins commented 2 years ago

Thank a lot for your review Galou. s-quirin made all your request changes and I just add it to my master

galou commented 2 years ago

Thank you both for your contribution and your patience!