FreeCAD / FreeCAD-macros

A repository for FreeCAD macros
https://freecad.org/wiki/Macros_recipes
156 stars 139 forks source link

[CadbaseLibrary] Fixes #144

Closed mnnxp closed 1 year ago

mnnxp commented 2 years ago

Thank you for creating a pull request to contribute to FreeCAD-macros! To integrate your macro please make sure the following steps are complete:

And please remember to update the Wiki with the features added or changed once this PR is merged.
Note: If you don't have wiki access, then please mention your contribution on the 0.19 Changelog Forum Thread.


I tried to correct the code according to the previous remarks from @galou https://github.com/FreeCAD/FreeCAD-macros/pull/136

luzpaz commented 1 year ago

@galou are you available to review this PR ?

mnnxp commented 1 year ago

Using a macro, users can download files from the platform, but can't upload to the platform (they need to use the platform website to do so). Hopefully soon I will to add this functionality to the macro. Sorry if the code doesn't look good again. And of course I will be ready to correct if I am told about my errors.

mnnxp commented 1 year ago

@galou thank you very much for this code review! ~I will fix the code according to your remarks in the next update, I will try to make it big so as not to distract you so often with minor fixes.~ I'm very sorry, but I forgot to add new files in the macro description and they are not downloaded with the macro... Soon I'll fix it in the new PR :(