FreeCAD / FreeCAD-macros

A repository for FreeCAD macros
https://freecad.org/wiki/Macros_recipes
145 stars 134 forks source link

[CadbaseLibrary] Update to v0.2.0: add functionality for uploading files #155

Closed mnnxp closed 1 year ago

mnnxp commented 1 year ago

Thank you for creating a pull request to contribute to FreeCAD-macros! To integrate your macro please make sure the following steps are complete:

And please remember to update the Wiki with the features added or changed once this PR is merged.
Note: If you don't have wiki access, then please mention your contribution on the 0.19 Changelog Forum Thread.


Sorry for the long message in the first commit.

A video on how this macro works (02:20): https://youtu.be/ONtNrYrg3HU

mnnxp commented 1 year ago

@galou thank you for the review!

Sorry if I made the wrong choice between macro and workbench.

I assumed that the interface of this macro could be run separately from the active workbench so that the user does not have to switch from the active workbench. If this choice is wrong, then yes, I will consider how to change it.

galou commented 1 year ago

The choice is not wrong, there's no real difference between macro and workbench. You can also install global toolbars for workbenches. The advantage for you is that you won't need to go through the peer review.

As soon as you have your workbench ready (by the way, this will be in a separate repo), just write a PR to delete the macro (add a link to the new repo to the commit message then).