search

FreeCAD / FreeCAD-macros

A repository for FreeCAD macros
https://freecad.org/wiki/Macros_recipes
145 stars 134 forks source link

Invalid license for SketcherOffset.FCMacro #167

Open chennes opened 4 months ago

chennes commented 4 months ago

This macro contains a __license__ entry, but does not specify a valid license there. The line should be removed, or a valid SPDX license identifier put in place. https://github.com/FreeCAD/FreeCAD-macros/blob/25fcaf70eb49c7ba68d1b7958404ae104e15430c/Sketcher/SketcherOffset.FCMacro#L14

galou commented 4 months ago

@edi271 can you please react to this?

Maybe we could remove the macro since offset is now implemented natively in Sketcher?

edi271 commented 4 months ago

The Offset tool implemented in the Sketcher is working in an other way, that means, it returns in some situations other results than the macro. If you think best, please remove the macro.

galou commented 4 months ago

I don't have anything against letting the macro here if it behaves differently. Moreover, it's a well-written macro that can serve as a reference for many things.

What about the license? I can make the change myself if you name one.