search

FreeCAD / FreeCAD-snap

The official Snap package of the FreeCAD project
https://snapcraft.io/freecad
8 stars 9 forks source link

Update snap edge/beta to OCC 7.7.2 #69

Open luzpaz opened 1 year ago

luzpaz commented 1 year ago

Per wwmayer OCC 7.7.0 compiles fine with latest FreeCAD HEAD. We should add it to snap edge in that case

adrianinsaval commented 1 year ago

link to forum discussion: https://forum.freecadweb.org/viewtopic.php?p=639505#p639505

adrianinsaval commented 1 year ago

you'll need to change this to V7_7_1_BF https://github.com/FreeCAD/freecad-deps-core20-snap/blob/d58e75c254cb308d46dc522a6a3211767b092725/snap/snapcraft.yaml#L25

it's possible that you will need to move to core 22 also: https://github.com/FreeCAD/freecad-deps-core20-snap/blob/d58e75c254cb308d46dc522a6a3211767b092725/snap/snapcraft.yaml#L2

occt 7.7 requires tbb >=2021.5 which I doubt would be in ubuntu 20.04

luzpaz commented 1 year ago

occt 7.7 requires tbb >=2021.5 which I doubt would be in ubuntu 20.04

You're right, @adrianinsaval. Do you know if I can keep things as they are for stable and change OCC and core 22 just for snap edge and snap beta builds?

  Ubuntu 20.04 package Packaging status

adrianinsaval commented 1 year ago

I would expect yes, but I'm not all that familiar with how making snaps work

adrianinsaval commented 1 year ago

There's some bugs with occt 7.7.1 that I don't think we're going to fix before release, I'll move this out of the 0.21 project. Better to do this next cycle.

luzpaz commented 11 months ago

7.7.2 released: https://dev.opencascade.org/content/open-cascade-technology-772-maintenance-release

chennes commented 11 months ago

Are we not building Blobfish for the snaps? I should fix if not.

adrianinsaval commented 11 months ago

we are using blobfish: https://github.com/FreeCAD/freecad-deps-snap/blob/d58e75c254cb308d46dc522a6a3211767b092725/snap/snapcraft.yaml#L24-L25

luzpaz commented 11 months ago

has blobfish rebased his patches on 7.7.2 yet ?

chennes commented 11 months ago

I don't think so: the latest I see is 7.7.1BF https://gitlab.com/blobfish/occt/-/tree/V7_7_1_BF?ref_type=heads

adrianinsaval commented 11 months ago

the blobfish patch set keeps growing but none of it is going upstream, should we worry about that? Can we do something to get those merged upstream?

luzpaz commented 11 months ago

Maybe we can forge a relationship with upstream (there is a gentleman that has represented OCC in previous FLOSS conferences) and have a (paid?) liason work to merge patches ?

chennes commented 11 months ago

We cannot "merge" his code upstream, he has not signed the OpenCASCADE developer agreement, and is not interested in doing so. His patches would have to be rewritten.

adrianinsaval commented 11 months ago

Ugh, I wish they would drop that silly requirement.