search

FreeCAD / FreeCAD-snap

The official Snap package of the FreeCAD project
https://snapcraft.io/freecad
9 stars 10 forks source link

Update for change in application id to org.freecad.FreeCAD #97

Closed cjmayo closed 1 year ago

cjmayo commented 1 year ago

appdata, desktop and scalablie icon files renamed in:

https://github.com/FreeCAD/FreeCAD/commit/9b562a4e0a ("Finish renaming desktop filename to org.freecad.FreeCAD", 2023-08-08)

I don't have the ability to test this myself...

Possibly common-id should not have a .desktop suffix? https://snapcraft.io/docs/using-external-metadata#heading--appstream

chennes commented 1 year ago

Re: common-id, the docs say "For backwards compatibility, some component ids in the AppStream metadata have a .desktop suffix. If this is the case for your application, the common-id of your app should also use that suffix." Does that apply to us?

cjmayo commented 1 year ago

Our component has an id without .desktop:

https://github.com/FreeCAD/FreeCAD/blob/6bb6c0c8860d077a49ba2e0009c979661af6a6f9/src/XDGData/org.freecad.FreeCAD.appdata.xml.in#L3

but that page in the docs is about parsing external metadata which I don't think we are doing, so that probably doesn't actually matter.

There was something about integrating with desktop software stores and being able to search by common-id:

https://forum.snapcraft.io/t/search-by-common-id/6136

But, I don't used Snaps so I'm definitely not suggesting what to do here. It was just something I came across when I was checking what I had broken!