[Issue] ProDark: Light text background colors result in illegible text

[life5ign]

Is there an existing issue for this?

• [X] I have searched the existing issues

Forums discussion

https://forum.freecadweb.org/viewtopic.php?f=34&t=55134&p=649728#p649728

(I mentioned it as a comment on today's date, on page 15, but decided to just file the issue here since I had all the screenshots prepared).

Version

0.20 (Release)

Full version info

[code]
OS: Pop!_OS 22.04 LTS (pop:GNOME/pop)
Word size of FreeCAD: 64-bit
Version: 0.20.1.29410 (Git) AppImage
Build type: Release
Branch: (HEAD detached at 0.20.1)
Hash: f5d13554ecc7a456fb6e970568ae5c74ba727563
Python 3.10.5, Qt 5.15.4, Coin 4.0.0, Vtk 9.1.0, OCC 7.6.2
Locale: English/United States (en_US)
Installed mods: 
  * Rocket 2.8.5
  * fasteners 0.4.27
  * Help 1.0.3
  * parts_library
  * lattice2 1.0.0
  * Curves 0.6.5
  * LCInterlocking
  * A2plus 0.4.60g
  * FreeCAD-library-eac93dcfa999af5c1b2682eda999fbac9f4d63df.zip
[/code]

Subproject(s) affected?

None

Issue description

Excellent theme! I've noticed on my system that certain text, when highlighted, has a white or a yellow background, which, with the white text, makes it illegible:

Active Part or Body in Combo View tree:

Annotation in TechDraw:

my system

Anything else?

I tried resetting all in my Prefereneces, as well as uninstalled all preference packs, restarted freecad, and it didn't fix the issue. This is how it looks with no style sheet:

It's a bit of a drag to not be able to read the name of the active part and body; the annotations is a bit less of an annoyance. Please let me know if there's any other information you need, and thanks for all the work you do to help us build and create.

Code of Conduct

• [X] I agree to follow this project's Code of Conduct

[adrianinsaval]

this is not directly related to stylesheet as it is either hardcoded or a preference, please see https://github.com/FreeCAD/FreeCAD/issues/7623#issuecomment-1287544999 https://forum.freecadweb.org/viewtopic.php?p=635039#p635039 and https://forum.freecadweb.org/viewtopic.php?f=34&t=70672

[life5ign]

Hi, thanks for the reply--I can't believe I didn't find any of those in my google, forum, github searches. Thanks, looks like the team is aware of it.

[MisterMakerNL]

Hey thanks for reporting. The first issue is fixed in my extremeprodark, but you need too restart Freecad. And apply the preference pack as it's not in the theme file. The second issue I was sure we fixed it, or looked into it but I can't find where it was discussed.

[life5ign]

Thanks! I just installed extremeprodark (great theme), and the first is definitely fixed, but I still get the issue with annotations in techdraw:

[adrianinsaval]

yeah that's not themable IIRC, IMO the real issue is that we are using the wrong widget type for this, we are using a text editor to edit a list and adding some workarounds to have line highlight, instead of just using QListWidget that is made for lists and would have highlighting that is themable.

[WandererFan]

TechDraw Annotation fixed by PR FreeCAD/FreeCAD#8123 / d63ac0f7f6

[luzpaz]

Can this be closed ?

[WandererFan]

Can this be closed ?

No. The PropertyEditor still uses the old QLineEdit based editor for PropertyStringList, which doesn't respect themes.

[luzpaz]

@WandererFan should the ticket then be renamed ?

[WandererFan]

No need to rename the ticket, the PropertyEditor has the same illegible text in dark mode.

[Intuos5]

There's another window I came across that has inelligible text: This is in the Dark-Orange stylesheet.

I also modified the Darker-Green stylesheet and had the same issue there: See: https://forum.freecadweb.org/viewtopic.php?style=2&p=655842#p655842

[MisterMakerNL]

@Intuos5 This seems to be a stylesheet issue as I don't have this in my ExtremeProDark-theme. But I was also pretty strict with my theme, like all the text fields that you could edit are black and normal text is always white. I can see that certain combination of text styles and text boxes can cause this issue, which was a pain to figure out in the old theme templates even almost impossible to fix as some styles where grouped together. This is why I started from scratch with mine.
Edit I see they are also missing the bottom corner drag handle.

[MisterMakerNL]

All of these are pretty much fixed by now. Although some are a bit of a workaround like adding

          <FCParamGroup Name="Spreadsheet">
            <FCText Name="AliasedCellBackgroundColor">#9b4de6</FCText>
          </FCParamGroup>

Too the Stylesheet CFG file. @WandererFan did a great job on fixing it on his part! Can go further in how to fix all the old style-sheets.... here https://github.com/FreeCAD/FreeCAD/issues/7623 As far as I see it this can be closed.

[Intuos5]

@MisterMakerNL will the spreadsheet's aliased cell colour be added to the preferences? If not, it is not fixed for the default themes and cannot be closed. A "paste this code" isn't going to cut it as a solution (for new users).

[luzpaz]

bumping for status

[MisterMakerNL]

Pro dark has been removed from main to the theme, repro. This can be moved or closed, for the other theme's we have other topics.

[luzpaz]

Can this be closed ?

No. The PropertyEditor still uses the old QLineEdit based editor for PropertyStringList, which doesn't respect themes.

@WandererFan checking in

[obelisk79]

@maxwxyz this should either be moved to the FreeCAD-themes repo or closed.

[luzpaz]

Moved to FreeCAD-themes repo