FreeCAD / FreeCAD-translations

Repository tracking localization issues and progress
5 stars 3 forks source link

TechDraw → TechDraw Centerlines (toolbar) → Change Line Attributes (tool) and others #239

Closed kaktusus closed 1 year ago

kaktusus commented 1 year ago
OS: Debian GNU/Linux 12 (bookworm) (KDE/plasma)
Word size of FreeCAD: 64-bit
Version: 0.21.0.33303 (Git) AppImage
Build type: Release
Branch: master
Hash: 5b075a9938b78076fdde9034de4a05685e42690e
Python 3.10.11, Qt 5.15.8, Coin 4.0.0, Vtk 9.1.0, OCC 7.6.3
Locale: Polish/Poland (pl_PL)
Installed mods: 
  * Curves 0.5.0
  * sheetmetal 0.2.56
  * Reinforcement
  * BIM 2021.12.0
  * Rocket 3.1.0

Window title without translation.

image

TechDraw Cosme.../Perpendicular - I don't even know what it says I'm guessing that this string is not in Crowdin.

image

TechDraw Cosmetic Circle - no string in Crowdin https://crowdin.com/translate/freecad/all/en-pl?filter=basic&value=0#q=TechDraw%20Cosmetic%20Circle

image

TechDraw Cosme...ion Vertex(es) - I don't even know what it says I'm guessing that this string is not in Crowdin.

image

TechDraw Circle Centerlines - no string in Crowdin https://crowdin.com/translate/freecad/all/en-pl?filter=basic&value=0#q=TechDraw%20Circle%20Centerlines

Component Add Cosmetic Thread Hole Side View has this window with translated text but the title is not readable because the window is too narrow.

Too narrow window and unreadable title is a global problem for FreeCAD Should I generate some generic ticket for this inconvenience?

WandererFan commented 1 year ago

This one also looks like it should be translatable:

sAppModule = "TechDraw";
sGroup = QT_TR_NOOP("TechDraw");
sMenuText = QT_TR_NOOP("Add Circle Centerlines");
sToolTipText = QT_TR_NOOP("Add centerlines to circles and arcs:<br>\
chennes commented 1 year ago

The fix for this is the same as for https://github.com/FreeCAD/FreeCAD-translations/issues/240 -- it's not the command itself that is the problem, it's the use of _checkSel with a string that is never provided to the translation system in CommandExtensionPack.cpp. This is present in at least two files: are there others? Also, I think there's another, similar function, at least in CommandExtensionDims.cpp (_checkSelAndObj or something) that has the same problem.

kaktusus commented 1 year ago

Good thing you're back from leave ... as you can see without you nothing could be done ....

kaktusus commented 1 year ago

still needs attention