Material: materials-editor.ui not installed in the correct location

nickoe commented 1 month ago

Is there an existing issue for this?

[X] I have searched the existing issues

Problem description

I was trying to build freecad via the freecad-git package on ArchLinux AUR.

I ran namcap on the generated package, and noticed that materials-editor.ui was copied/installed outside the the pkg dir aka the DESTDIR location for the cmake install target.

This appears to be caused by a type caused by the addition of the ui file in commit 810f34ea11dca01ee833e7c625f87feac39ae2c1

I will submit a PR for this.

Full version info

Self build on commit c5408de52591f4a1dfebe14a2a3b589af58d1f3d (origin/main, origin/HEAD)

Subproject(s) affected?

Other (specify in description)

Anything else?

No response

Code of Conduct

[X] I agree to follow this project's Code of Conduct

luzpaz commented 1 month ago

Looks like a dupe of #15571

nickoe commented 1 month ago

@luzpaz Oh, yes indeed :S I have created the PR for the ui file

luzpaz commented 1 month ago

Can you notate the other ticket, pls? TIA :pray:

nickoe commented 1 month ago

Yeah, so I just compared with the CMakeLists.txt in the FEM/Gui dir, and it does it a bit differently.

Maybe @adrianinsaval 's fix is more correct. https://github.com/FreeCAD/FreeCAD/pull/15565/commits/b9a2735306461973cbb4520c1b53563e8849ec53

UPDATE:

I don't appear to the have the issue mentioned in with the libFreeCAD_widgets.so

Tested with my patch ee1fa4e8dfc4a5cd0613474231967c12cf7c1b4a

$ find ../../ -name libFreeCAD_widgets.so
../../src/build/src/Tools/plugins/widget/libFreeCAD_widgets.so
../../pkg/freecad-git/usr/lib/qt6/plugins/designer/libFreeCAD_widgets.so

Checking with comment https://github.com/FreeCAD/FreeCAD/pull/15565#issuecomment-2249207487

In think my patch is correct as it installs to:

$ find ../../ -name MaterialWorkbench.svg
../../src/FreeCAD/src/Mod/Material/Gui/Resources/icons/MaterialWorkbench.svg
../../src/build/usr/share/freecad/Mod/Material/Resources/icons/MaterialWorkbench.svg
../../pkg/freecad-git/usr/share/freecad/Mod/Material/Resources/icons/MaterialWorkbench.svg

nickoe commented 1 month ago

Can you notate the other ticket, pls? TIA 🙏

@luzpaz I updated my commit to include the other issue number, see commit: d2b01ad6acce1dd41e5ef948f19706fe2d8de3ea

maxwxyz commented 2 weeks ago

Duplicate of https://github.com/FreeCAD/FreeCAD/issues/15571

FreeCAD / FreeCAD