search

FreeCodeCampHongKong / FreeCodeCampHongKong.github.io

The Official Website for FreeCodeCamp Hong Kong
https://freecodecamphongkong.github.io/
0 stars 2 forks source link

instructions required: how to create pull requests #15

Open gregorywong opened 7 years ago

gregorywong commented 7 years ago

As mentioned in issue #11 :

There needs to be some instructions on how to create pull requests on GitHub (specific to our org). We could possibly reference this tutorial on pull requests by GitHub guides: https://guides.github.com/activities/hello-world/

Contributor(s):

Reviewer(s):

isaackwan commented 7 years ago

How do I become a reviewer:P?

gregorywong commented 7 years ago

@isaackwan Don't think there's a way to distinguish between the writer(s) and reviewer(s), so I've updated the description to reflect that!

I may try to write the instructions if no one else takes up the task :P

andrealaw commented 7 years ago

Is it necessary to list out the reviewers/contributors explicitly? As Github automatically logs all changes for us.

Example from our wiki page: https://github.com/FreeCodeCampHongKong/FreeCodeCampHongKong.github.io/wiki/How-to-synchronize-local-repository-with-the-latest-version-on-Github/_history

gregorywong commented 7 years ago

@andrealaw This is just for this task specifically (more for my own reference). Since I might not be able to work on it right away, it'll be good to have a summary of our discussion to refer to later, instead of having to go through the conversation log each time.