issues
search
FreeCol
/
freecol
FreeCol: FreeCol is a turn-based strategy game based on the old game Colonization, and similar to Civilization. The objective of the game is to create an independent nation.
GNU General Public License v2.0
581
stars
170
forks
source link
improve compact colony report
#115
Open
zeitlinger
opened
2 years ago
zeitlinger
commented
2 years ago
show good production in blue (i.e. good) if all required buildings are built (including factories, even if factories are not available yet)
show bells and hammers, too - this makes it easier to see
if all buildings are built (see above)
if there is a production warning for hammers - this should have worked by showing underconsumption for lumber, but this was confusing and didn't work
don't show underconsumption anymore - always show the warning on the good being produced
it's not a warning anymore if the net production is negative (to make all warnings and alerts actionable)
add a new column showing workers that are not working
this includes persons and excludes expert soldiers, units that are fortified, improving or already have a destination
add a column showing units that are working, but not working in their profession
Future work
the warning color is hard to see - I would propose some some yellow (second screenshot), but that's not included in the PR yet
similarly, the export color is indistinguishable from the alert color for people with red-green weakness, so I've tried out white (second screenshot)
the trade advisor should probably be changed to align with the new logic (good warnings, colors) - it can probably use the same logic under the hood
Note
this is a very big PR, partly because I started by extracting methods from the report before making changes
I can split the PR into multiple PRs if this helps the review process
Future work
Note