FreeCol / freecol

FreeCol: FreeCol is a turn-based strategy game based on the old game Colonization, and similar to Civilization. The objective of the game is to create an independent nation.
GNU General Public License v2.0
581 stars 170 forks source link

Game hangs: WARNING: Illegal move for: unit:6567 type: MOVE_NO_ACCESS_LAND #118

Closed ingmar closed 1 year ago

ingmar commented 1 year ago

I think the relevant log messages are these:

net.sf.freecol.client.gui.panel.InfoPanel update INFO: InfoPanel updated UNIT -> UNIT with unit [unit:6567 dutch merchantman 4/5] Fri Aug 19 14:52:12 CEST 2022 Thread: 30 net.sf.freecol.common.model.Player clientError WARNING: Illegal move for: unit:6567 type: MOVE_NO_ACCESS_LAND from: tile:2996 to: tile:2995 Fri Aug 19 14:52:12 CEST 2022 Thread: 205916 net.sf.freecol.common.model.Player clientError WARNING: Illegal move for: unit:6567 type: MOVE_NO_ACCESS_LAND from: tile:2996 to: tile:2995 Fri Aug 19 14:52:12 CEST 2022 Thread: 205917 net.sf.freecol.common.model.Player clientError WARNING: Illegal move for: unit:6567 type: MOVE_NO_ACCESS_LAND from: tile:2996 to: tile:2995 Fri Aug 19 14:52:12 CEST 2022 Thread: 205918 net.sf.freecol.client.gui.panel.InfoPanel update INFO: InfoPanel updated UNIT -> UNIT with unit [unit:6567 dutch merchantman 4/5] Fri Aug 19 14:52:12 CEST 2022 Thread: 30 net.sf.freecol.common.model.Player clientError WARNING: Illegal move for: unit:6567 type: MOVE_NO_ACCESS_LAND from: tile:2996 to: tile:3035 Fri Aug 19 14:52:12 CEST 2022 Thread: 205919 net.sf.freecol.common.model.Player clientError WARNING: Illegal move for: unit:6567 type: MOVE_NO_ACCESS_LAND from: tile:2996 to: tile:2995 Fri Aug 19 14:52:12 CEST 2022 Thread: 205920 net.sf.freecol.common.model.Player clientError WARNING: Illegal move for: unit:6567 type: MOVE_NO_ACCESS_LAND from: tile:2996 to: tile:2995 Fri Aug 19 14:52:12 CEST 2022 Thread: 205921 net.sf.freecol.common.model.Player clientError WARNING: Illegal move for: unit:6567 type: MOVE_NO_ACCESS_LAND from: tile:2996 to: tile:2995 Fri Aug 19 14:52:12 CEST 2022 Thread: 205922 net.sf.freecol.common.model.Player clientError WARNING: Illegal move for: unit:6567 type: MOVE_NO_ACCESS_LAND from: tile:2996 to: tile:3035 Fri Aug 19 14:52:12 CEST 2022 Thread: 205923

This then repeats endlessly, filling up the logfile fast (the thread numbers seem to be constantly increasing). The game shows the error dialog with the link to the logfile and then freezes.

Last Autosave attached: Autosave-last-turn.zip

stiangre commented 1 year ago

A couple of bugs causing this problem were fixed yesterday. Please try our development build and check if the issue has been resolved for you.

ingmar commented 1 year ago

Seems fixed in https://github.com/FreeCol/freecol/commit/4aed94381f5b015ca024658c72a4a649ff0f09fc - nice work, and fast! 👍

stiangre commented 1 year ago

Great, thanks for reporting :-)