search

FreeCol / freecol

FreeCol: FreeCol is a turn-based strategy game based on the old game Colonization, and similar to Civilization. The objective of the game is to create an independent nation.
GNU General Public License v2.0
588 stars 173 forks source link

Remove special handling of goto clicks. #13

Closed Szunti closed 6 years ago

Szunti commented 6 years ago

There is a bug currently, because the tile is selected twice. First mousePressed saves the coordinates of the click and waits to know if another click comes. In the meantime mouseReleased calls flushGoto and selects the goal tile, but can also scroll the map if the unit centering option is set. After the doubleClickTimer fires, the saved coordinates are used to select the tile under the cursor, but after scrolling it is not the same tile anymore where the click started.

HighwayofLife commented 6 years ago

Hi @Szunti , there's a conflict in the merge, can you rebase and resubmit?

Szunti commented 6 years ago

I think this was solved by the confilcting commit, but I can't test because pressing g and left clicking is broken, it just selects the target tile instead of moving.

HighwayofLife commented 6 years ago

@Szunti is that another or new bug?

Szunti commented 6 years ago

New one.

Szunti commented 6 years ago

Mike Pope said here that middle click is the new left click, then everything works as intended. This can be closed.