Population growth ending with zero food leads to starvation

FreeCol / freecol

FreeCol: FreeCol is a turn-based strategy game based on the old game Colonization, and similar to Civilization. The objective of the game is to create an independent nation.

GNU General Public License v2.0

588 stars 173 forks source link

Population growth ending with zero food leads to starvation #30

Closed sumpfralle closed 4 years ago

sumpfralle commented 5 years ago

When a settlement ends up with 200 or more units of food, its population grows by one.

In case a settlement finishes with exactly 200 units of food, then one inhabitant of the settlement starves to death (even though the settlement produces a surplus of food) at the same turn. Thus the turn log contains two messages for the same settlement:

population grows
one citizen starved to death

This should not happen.

Version: nightly-2019-01-02

mpope042 commented 4 years ago

I am unable to reproduce this error. If it recurs, please open a bug report with an attached saved game that exhibits the problem.

sumpfralle commented 4 years ago

Thank you for taking the time to look into this issue.

I guess, it is fixed now. Next time I will attach the save game.

Thanks!