search

FreeCol / freecol

FreeCol: FreeCol is a turn-based strategy game based on the old game Colonization, and similar to Civilization. The objective of the game is to create an independent nation.
GNU General Public License v2.0
585 stars 170 forks source link

Preference added to flash the active unit #52

Closed TropicalBastos closed 4 years ago

TropicalBastos commented 4 years ago

As per reading the feedback from issue #24 I noticed the OP mentioned that he would like to flash selected units. So I implemented this and shielded it into a preference for people who would rather not have it.

It functions exactly like the blinking of the terrain cursor on active units except that it blinks the unit itself as well.

wintertime commented 4 years ago

Actually, flashing the active unit was an existing feature. When I saw a recent version, I actually wondered why it is bugged. It was annoying when I was just moving around units and often the terrain got selected without reason. There was a terrain view already, but the game knew when it was active and didn't switch to it without user request. I'll have to do some digging in history before reviewing, to know what happened to the old code for this.

HighwayofLife commented 4 years ago

That's what I thought as well... thought it used to flash the current unit. But I haven't played in a bit. Does it no longer do that?

TropicalBastos commented 4 years ago

Thanks for the info, I'm closing this anyways since I've been noticing some visual glitches on my Mac with this patch (although not sure why since the alpha setting is reset after drawing the unit).