search

FreeCol / freecol

FreeCol: FreeCol is a turn-based strategy game based on the old game Colonization, and similar to Civilization. The objective of the game is to create an independent nation.
GNU General Public License v2.0
585 stars 170 forks source link

added test case for saving map editor #61

Closed ch-zha closed 3 years ago

ch-zha commented 4 years ago

Added a test case for saving a map editor game

mpope042 commented 4 years ago

This is a very odd way to test saveMapEditorGame. Why no try/catch block? It is documented to throw an exception on error. Similarly, AFAICT there is no threading issue here, so the sleep seems unnecessary... did you see cases where saveMapEditorGame could return successfully without having created the file?

mpope042 commented 3 years ago

No action for a year, closing.