search

FreeCol / freecol

FreeCol: FreeCol is a turn-based strategy game based on the old game Colonization, and similar to Civilization. The objective of the game is to create an independent nation.
GNU General Public License v2.0
585 stars 170 forks source link

Sometimes AI assigns European units to worst producing tile #78

Closed bjorneg closed 3 years ago

bjorneg commented 3 years ago

Hi

It looks like the AI assigns European units to the least producing tile. Look at the English tobe Colony at 33, 85 (I play Dutch - so use --debug MENUS) At the next turn AI will assign one colonist to produce ore on the grain resource (34,86) and one unit producing grain at boreal forest (33, 83).

Save game file is attached: bug01_1494.zip

I think the bug is caused by a wrongly sorted workplan in ColonyPlan.java. A patch is attached as well. (https://github.com/FreeCol/freecol/files/5860502/Order-colony-resources-from-best-to-worst-in-workpla.zip)

I have played a couple of games with the patch applied and it works ok for me. I have not noted any side-effects with the patch applied.

I am at master 75e1cf3.

/////Björne

Calebrw commented 3 years ago

Can you create a pull request?

bjorneg commented 3 years ago

PR #79

Calebrw commented 3 years ago

Merged. Should make the game better.